Add a "Setup Python" action for github-hosted runners and remove unnecessary CUSTOM_MINGW environment variable
#125590
Conversation
rustbot
added
A-testsuite
ChrisDenton
changed the title
CUSTOM_MINGW environment variableCUSTOM_MINGW environment variable
|
Just to make sure that I understand the context, a custom MinGW was needed in the past, because the GitHub Windows runners had too old OS? Or is the reason that it is not needed now the fact that we have updated our minimum supported Windows versions? |
The windows-gnu runners do need a custom mingw to build rustc but they always need it so there's no reason to make it configurable via an environment variable. The script that uses The windows-msvc runners don't need mingw to build rust as they use MSVC and LLVM tools. I'm not entirely clear why we used to install gnu build tools on windows-msvc runners but presumably it was needed at some point in the past. CI does need a way to run bash scripts and support for run-make tests (e.g. having a gnu |
|
I see. Let's check if this works. @bors try |
Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable The Setup Python action isn't strictly necessary ([even on Windows](rust-lang#125584)) but it is [recommend by GitHub](https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#specifying-a-python-version). The `CUSTOM_MINGW` environment variable is redundant now as it's always set for mingw and always unset otherwise. try-job: x86_64-mingw try-job: x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-mingw
|
☀️ Try build successful - checks-actions |
|
Looks like it works. @bors r+ |
bors
added
S-waiting-on-bors
Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable The Setup Python action isn't strictly necessary ([even on Windows](rust-lang#125584)) but it is [recommend by GitHub](https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#specifying-a-python-version). The `CUSTOM_MINGW` environment variable is redundant now as it's always set for mingw and always unset otherwise. try-job: x86_64-mingw try-job: x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-mingw
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#117671 (NVPTX: Avoid PassMode::Direct for args in C abi) - rust-lang#124251 (Add an intrinsic for `ptr::metadata`) - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) - rust-lang#125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable) - rust-lang#125598 (Make `ProofTreeBuilder` actually generic over `Interner`) - rust-lang#125637 (rustfmt fixes) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#117671 (NVPTX: Avoid PassMode::Direct for args in C abi) - rust-lang#125573 (Migrate `run-make/allow-warnings-cmdline-stability` to `rmake.rs`) - rust-lang#125590 (Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable) - rust-lang#125598 (Make `ProofTreeBuilder` actually generic over `Interner`) - rust-lang#125637 (rustfmt fixes) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#125590 - ChrisDenton:mingw-ci-3, r=Kobzol Add a "Setup Python" action for github-hosted runners and remove unnecessary `CUSTOM_MINGW` environment variable The Setup Python action isn't strictly necessary ([even on Windows](rust-lang#125584)) but it is [recommend by GitHub](https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python#specifying-a-python-version). The `CUSTOM_MINGW` environment variable is redundant now as it's always set for mingw and always unset otherwise. try-job: x86_64-mingw try-job: x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-mingw
|
The setup Python action doesn't work for |
|
Seems fine to remove it. I don't think there's any particular reason we need it. |
|
Ok, posted #126116. |
CI: remove `Setup Python` action This action was added recently in rust-lang#125590, but it shouldn't really be needed, as our CI was working fine before without it. Our base Ubuntu 20.04 images use Python 3.8, while this action installed Python 3.12, but we don't really need that. Since this action does not support ARM yet, this blocks rust-lang#126113. See rust-lang#125590 (comment). r? `@jdno`
CI: remove `Setup Python` action This action was added recently in rust-lang/rust#125590, but it shouldn't really be needed, as our CI was working fine before without it. Our base Ubuntu 20.04 images use Python 3.8, while this action installed Python 3.12, but we don't really need that. Since this action does not support ARM yet, this blocks rust-lang/rust#126113. See rust-lang/rust#125590 (comment). r? `@jdno`
The Setup Python action isn't strictly necessary (even on Windows) but it is recommend by GitHub.
The
CUSTOM_MINGWenvironment variable is redundant now as it's always set for mingw and always unset otherwise.try-job: x86_64-mingw
try-job: x86_64-mingw
try-job: dist-x86_64-msvc
try-job: dist-x86_64-mingw